-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set no_implicit_reexport = true in pyproject.toml
#4211
Set no_implicit_reexport = true in pyproject.toml
#4211
Conversation
pyproject.toml
Codecov Report
@@ Coverage Diff @@
## master #4211 +/- ##
==========================================
- Coverage 64.17% 64.11% -0.06%
==========================================
Files 457 457
Lines 75611 75613 +2
==========================================
- Hits 48521 48483 -38
- Misses 27090 27130 +40
Continue to review full report at Codecov.
|
I should link #4044 |
b5d6d80
to
d695639
Compare
@@ -28,3 +28,34 @@ | |||
) | |||
from .series import Series, wrap_s | |||
from .whenthen import when # used in expr.clip() | |||
|
|||
__all__ = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not include argsort_by
, date_range
, and _deser_and_exec
in this list? These are now imported but not available through __all__
.
Same for the other __init__
file, there are a few instances missing from __all__
, like Null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only because mypy
didn't complain about them, meaning they are not imported from anywhere else in the codebase. It might better to remove them as imports from the __init__
than to add them to __all__
. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, let's keep that for a different PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I mentioned before that I want to avoid using typing.cast
if at all possible, but this seems like a valid use case. Nice work.
One step closer to enabling
strict = true
formypy
.