feat(rust): Initial implementation of histogram algorithm #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been using this in a branch long enough, I forgot it hasn't been merged yet. Any chance we could hit the button? |
|
Sorry for the delay. Can you do a rebase on master? |
|
Ok, this should be all cleaned up now. |
|
Thanks @hpux735. A bit delayed, but here we go! |
stinodego
changed the title
github-actions
bot
added
the
enhancement
stinodego
changed the title
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the Discord, and to further support this issue, I've implemented a dedicated histogram function. It's very similar to
cut()in implementation (uses asof_join), but it keeps categories of the bin series that have zero counts. It's not expected to have bins missing in a histogram just because the count is zero.