Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust,python): Fix timezone cast #5016

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(rust,python): Fix timezone cast #5016

merged 1 commit into from
Sep 28, 2022

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Sep 28, 2022

Compute the offset from old to new timezone, instead of from UTC.

Supersedes: #5014

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Sep 28, 2022
@ritchie46 ritchie46 merged commit 2cf3d7b into master Sep 28, 2022
@ritchie46 ritchie46 deleted the timezone_cast branch September 28, 2022 13:19
@dpatton-gr
Copy link
Contributor

I might be wrong but can't this be done more simply by simply calling naive_local() on the converted datetime (as per #5014)?

@stinodego stinodego changed the title fix[rust]: fix timezone cast fix(rust,python): fix timezone cast Oct 1, 2022
@stinodego stinodego changed the title fix(rust,python): fix timezone cast fix(rust,python): Fix timezone cast Oct 1, 2022
@github-actions github-actions bot added the fix Bug fix label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants