Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust, python): projection_node always do projection locally if no… #5090

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

ritchie46
Copy link
Member

…t pruned

fixes #5086

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 3, 2022
@alexander-beedie
Copy link
Collaborator

Barely had time to get home and eat dinner and there's already a patch! 🚀
Fantastic... :)

@ritchie46
Copy link
Member Author

ritchie46 commented Oct 3, 2022

Barely had time to get home and eat dinner and there's already a patch! 🚀 Fantastic... :)

Yes.. I made the projection optimization better, but there are few edge cases coming in here and there. :(

@ritchie46 ritchie46 merged commit 102723e into master Oct 3, 2022
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Oct 3, 2022

Heh. It's always the optimisations that get you - even basic column pruning/pushdown has surprising edge-cases (especially in conjunction with joins). And I have to contend with multiple backends, with different rules for each... :)

I'm going to have a block of time coming up later in the month (significant other will be away for 2-3 weeks); should be able to make some progress on that parametric testing concept with chains of optimised/non-optimised operations 👍

@ritchie46
Copy link
Member Author

Ah.. 2 weeks if man-cave can lead to great things. That will be the guard rails of future optimizations! :)

@ritchie46 ritchie46 deleted the projection branch November 26, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

projection_pushdown regression/error from >= 0.14.15 (changes types, causes SchemaMismatch Error)
2 participants