Accept quote_char in SplitLines constructor to properly parse newlines #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es inside string fields when using a non-default quote character.
Yeah, I agree we could/should do that more top level in the API. Once a quote char is/or is not provide by the user we immediately should unwrap and only deal with a We do already have breaking code, so changes that clean up our code dispatch are welcome. Also in public API's. |
zundertj
pushed a commit
to zundertj/polars
that referenced
this pull request
Jan 7, 2023
…perly parse newlines (pola-rs#5143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small bug when using newlines inside string fields while using a custom quote character. Also includes an unit test and an integration test to make sure the parameter propagates down properly.
Function API could perhaps be cleaned-up a little by making
next_line_position()accept au8value directly and unwrapping inget_line_stats()but as these functions are markedpublicI am nowhere near comfortable enough to make that decision.