refactor(python): remove multiprocessing check, and leave it to the user #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
2 tasks
2 tasks
zundertj
pushed a commit
to zundertj/polars
that referenced
this pull request
Jan 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems are documented and I want to leave the responsibility of this at the end user. It is still perfectly valid to use multi-processing with any other library as long as polars is not used in the multiprocessing code.
I can imagine someone using pool.map over some function that does not use polars. That should be possible without us interfering with how people use mp.
Though, if they use polars in mp, they are warned and will hopefully quickly read our user guide with a dedicated issue on this or earlier issues on the topic.