fix(python): fix for categorical inserts from row-oriented data #5462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5457.
Delay application of
Categorical
type until after initial load when initialisingDataFrame
from row-oriented data. Fixesthread '<unnamed>' panicked at 'Categorical(None)
.Update: also spotted that the same issue would occur on insert from
@dataclass
and/orNamedTuple
data (which is also naturally row-oriented) and fixed that too.Test coverage added for all of the above.