feat(rust): Get polars to compile to wasm target #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just wanted to add a note: this is the fork that is currently being used for https://github.com/pola-rs/js-polars, so we can switch that to the main repo afterwards. |
|
Thanks a lot @gitkwr. Could you resolve the conflicts? Maybe if you have time, you could also add a wasm check in our CI. This would ensure we don't break this functionality in the future. |
|
@ritchie46 conflict resolved. Will look into wasm tests. |
|
I will merge this in before we get new conflicts. The wasm CI test can go in a new PR. Thanks for your work @gitkwr |
ritchie46
changed the title
github-actions
bot
added
enhancement
zundertj
pushed a commit
to zundertj/polars
that referenced
this pull request
Jan 7, 2023
Co-authored-by: Kival Mahadew <kivalm@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates that will allow polars to be compiled to webassembly target. Well tested and working.