Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): series of empty structs #6347

Merged
merged 5 commits into from
Jan 21, 2023
Merged

fix(rust, python): series of empty structs #6347

merged 5 commits into from
Jan 21, 2023

Conversation

universalmind303
Copy link
Collaborator

closes #6148
closes #6345

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jan 20, 2023
@universalmind303
Copy link
Collaborator Author

universalmind303 commented Jan 20, 2023 •
edited
Loading

I think this could be optimized further by implementing from_chunks for StructChunked, then we could bypass some of the iterating & rechunking happening in StructChunked::new_unchecked

@ritchie46
Copy link
Member

Thanks @universalmind303. LGTM on first side. 👍

@ritchie46 ritchie46 changed the title fix(rust): series of empty structs fix(rust, python): series of empty structs Jan 21, 2023
@github-actions github-actions bot added the python Related to Python Polars label Jan 21, 2023
@ritchie46 ritchie46 merged commit b87ac5d into pola-rs:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
2 participants
@universalmind303 @ritchie46