Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): deprecate columns param for DataFrame init; transitioning to schema #6366

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 22, 2023

Here we go... deprecating columns in favour of schema for DataFrame init, tying in with the recent addition of schema_overrides. Can continue to use columns while we transition (which we may want to do over an extended period, given how ubiquitous it is).

  • Transition is managed via the usual @deprecate_alias decorator.
  • Updated external and internal interfaces.
  • Updated/improved docstrings.
  • Updated tests.

This can release at any time, as it's not a breaking change.

For the next breaking release, I'll make a slight param reorder so that schema and schema_overrides are adjacent in all constructor methods.

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality labels Jan 22, 2023
@alexander-beedie alexander-beedie changed the title refactor(python): deprecate columns param; transitioning to schema refactor(python): deprecate columns param for DataFrame init; transitioning to schema Jan 22, 2023
@ritchie46
Copy link
Member

Nice! :)

@ritchie46 ritchie46 merged commit 1b4defb into pola-rs:master Jan 22, 2023
@alexander-beedie alexander-beedie deleted the deprecate-columns-for-schema branch January 23, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars refactor Code improvements that do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants