docs(python): added all missing examples for temporal expressions #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
reviewed
Jan 27, 2023
Comment on lines
+418
to
+420
| >>> start = datetime(2001, 1, 1) | ||
| >>> stop = datetime(2006, 1, 1) | ||
| >>> df = pl.DataFrame({"date": pl.date_range(start, stop, timedelta(days=180))}) |
There was a problem hiding this comment.
You seem to be a big fan of date_range 😄 I think the examples are fine, but would probably be clearer if you just hardcoded three datetimes in a dataframe. You already specified a start and stop, you're 2/3rds of the way there 😄
There was a problem hiding this comment.
Yeah I could do that, but most of the other functions for expressions use date_range to make a couple examples, so I used this so it's in line with the other examples.
There was a problem hiding this comment.
But I agree I can trim down the amount of rows in this example, the amount now is a bit overkill
stinodego
approved these changes
Jan 27, 2023
|
Thank you @romanovacca and @stinodego for the review. |
ritchie46
changed the title
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples for:
Note: I did not add examples for some functions that are going to be unified together. See #6445 for more info on this.