fix(rust, python): raise if tz_localize called on UTC-aware #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
commented
Jan 28, 2023
Comment on lines
-149
to
-151
| Some(tz) if tz == "UTC" => { | ||
| Ok(ca.with_time_zone(Some("UTC".into()))?.into_series()) | ||
| } |
There was a problem hiding this comment.
This was added in https://github.com/pola-rs/polars/pull/5522/files , but it looks like it's no longer necessary
There was a problem hiding this comment.
Hmm maybe the intention was to match the target tz? I'll update later, marking as draft for now
There was a problem hiding this comment.
I've rewritten according to what I think the intention was
MarcoGorelli
force-pushed
the
tz-localize-from-utc
branch
from
a2f2437
to
64484ec
Compare
|
Yeap.. 👍 |
cojmeister
pushed a commit
to cojmeister/polars
that referenced
this pull request
Jan 30, 2023
…6526) Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6525