-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(python): Use assert_frame_equal
instead of assert df.frame_equal(...)
#6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
Related to Python Polars
test
Related to the test suite
labels
Jan 29, 2023
stinodego
force-pushed
the
assert-frame-equal
branch
4 times, most recently
from
January 30, 2023 10:20
bd5bc1c
to
a944685
Compare
stinodego
force-pushed
the
assert-frame-equal
branch
from
January 30, 2023 16:03
a944685
to
56379bf
Compare
@ritchie46 Can this be merged? It's pretty big so very sensitive to merge conflicts. |
Yes! And thanks for the cleanup. It did expose some bugs. |
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Jan 30, 2023
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6364
assert_frame_equal
is more powerful as it checks dtypes as well, and has better error messages.I found a few bugs (these are now fixed in different PRs), as well as found a few tests that weren't asserting the equality (simply
df.frame_equal(expected)
without the assert 😄 )Random interesting tidbit
Different default dtypes for numpy arrays between Linux/Windows
This broke some tests, which I fixed by explicitly specifying the numpy dtype as
np.int64
.