fix(python): treat literal values consistently in select context, improve related typing
#6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one or as part of a list, improve related typing
stinodego
reviewed
Feb 2, 2023
You always leave great feedback - will take a look through and tweak accordingly :) (Update: done) |
alexander-beedie
force-pushed
the
literal-select-consistency
branch
from
0ccd6a3
to
bc4098e
Compare
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Feb 9, 2023
…mprove related typing (pola-rs#6628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6606.
df.select(value)anddf.select([value])- also addresses the same issue when usingwith_columns.PolarsExprTypePythonLiteral