Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): make string_repr private #6636

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

As reported on Discord:

>>> pl.Int16.string_repr()
TypeError: DataType.string_repr() missing 1 required positional argument: 'self'

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Feb 2, 2023
@stinodego
Copy link
Member

To be honest, that class should be private. It should only be used internally for printing dataframes. Use str(pl.Int16) if you want a string representation.

@MarcoGorelli
Copy link
Collaborator Author

MarcoGorelli commented Feb 2, 2023

ok yeah, if it's only meant for internal usage, that's probably better

is it worth going through a deprecation cycle, given it currently errors anyway for non-nested types (and so wouldn't reach the warning anyway)?

@MarcoGorelli MarcoGorelli changed the title fix(python): fix string_repr of non-nested types chore(python): make string_repr private Feb 2, 2023
@github-actions github-actions bot added the chore Maintenance work that does not impact the user label Feb 2, 2023
@stinodego
Copy link
Member

stinodego commented Feb 2, 2023

I don't think we have to deprecate it, we can just make it private, seeing it was broken anyway.

Pinging @ritchie46 to confirm - maybe he sees this differently.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 2, 2023 15:04
@ritchie46
Copy link
Member

Yeah, we can just make this private. If its not in our ref-guide it is not public. :)

@ritchie46 ritchie46 merged commit 90132e0 into pola-rs:master Feb 2, 2023
Vincenthays pushed a commit to Vincenthays/polars that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants