Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): unify nan_to_null and nan_to_none parameter names, expose to DataFrame init, add test coverage #6637

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

alexander-beedie
Copy link
Collaborator

Closes #6634.

  • Deprecates nan_to_none in favour of nan_to_null.
  • Exposes this param to DataFrame init for numpy arrays.
  • Adds some missing test coverage to validate nan_to_null behaviour.

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality labels Feb 2, 2023
@alexander-beedie alexander-beedie force-pushed the unify-nan-to-null branch 3 times, most recently from ff7bd83 to 414adad Compare February 2, 2023 15:50
…es, expose to DataFrame init, add test coverage
@ritchie46 ritchie46 merged commit 1f9bb06 into pola-rs:master Feb 3, 2023
@alexander-beedie alexander-beedie deleted the unify-nan-to-null branch February 3, 2023 18:07
Vincenthays pushed a commit to Vincenthays/polars that referenced this pull request Feb 9, 2023
…es, expose to DataFrame init, add test coverage (pola-rs#6637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars refactor Code improvements that do not change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should unify parameter names nan_to_none and nan_to_null, and their default value
2 participants