feat(rust): guarantee schema-stable col(dtype)
selection
#6674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
polars.datatypes.NUMERIC_DTYPES
) was not guaranteed to be stable between sessions/platforms/etc, as those dtype groups are set-based.Solution
Switch the inner/outer filter-order in
expand_dtypes
when determining which columns match.Guarantees stable column selection while maintaining the underlying schema-order.
Example
Before: (unstable column order - changes between sessions)
After: (stable, and schema-ordered)
Note
Selection in dtype order remains trivial (and each set of matching cols is also now stable), eg: