fix(rust, python): remove uses of rayon global thread pool #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a few spots where the rayon global thread pool is being used, and swapped them out with the internal pool. I was able to track down the spots by using a local version of rayon and adding a panic statement in the `set_global_registry` method which is invoked whenever the global thread pool is constructed. I'm not sure what the best way to enforce this is. One idea is to use test fixtures, and we can check if the global pool was used at the end of each test. Another could be to patch rayon when testing similar to what I did to detect the errors.
github-actions
bot
added
fix
|
Wow! Great catch. Thanks a lot. I think following up with a way to panic on tests is a great addition. |
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few spots where the rayon global thread pool is being used, and swapped them out with the internal pool. I was able to track down the spots by using a local version of rayon and adding a panic statement in the
set_global_registrymethod which is invoked whenever the global thread pool is constructed. I'm not sure what the best way to enforce this is. One idea is to use test fixtures, and we can check if the global pool was used at the end of each test. Another could be to patch rayon when testing similar to what I did to detect the errors.