Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust,python): return correct display/repr names for NaN-related expressions #6721

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Feb 8, 2023

Before (not distinguishable; all display as expr.nan())

str( pl.col('colx').is_nan() )
# 'col("colx").nan()'

str( pl.col('colx').is_not_nan() )
# 'col("colx").nan()'

str( pl.col('colx').drop_nans() )
# 'col("colx").nan()'

After (individual expression reprs)

str( pl.col('colx').is_nan() )
# 'col("colx").is_nan()'

str( pl.col('colx').is_not_nan() )
# 'col("colx").is_not_nan()'

str( pl.col('colx').drop_nans() )
# 'col("colx").drop_nans()'

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 8, 2023
@ritchie46 ritchie46 merged commit 5df0ce2 into pola-rs:master Feb 8, 2023
@alexander-beedie alexander-beedie deleted the nanfunc-repr-names branch February 8, 2023 08:53
Vincenthays pushed a commit to Vincenthays/polars that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants