feat(python): Improved assert equal messages #6737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
force-pushed
the
improve-assert-type-check
branch
from
17a39dc
to
a0c02e0
Compare
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6418
New message when inputs are not dataframes / series like expected.
DataFrames are different. Type mismatchInputs are different. Invalid input typesNew message when values do not match
DataFrames are different. Value mismatch-> includes values, but not the name of the Series!Values for column 'a' are different.-> Raised from another error that includes the valuesPlus some general cleanup like adding interpunction.