feat(rust, python): Support an ignore_nulls param for EWM calculations. (#5749) #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
yuntai
force-pushed
the
ewm_ignore_nulls
branch
2 times, most recently
from
f2f1169
to
578a87b
Compare
yuntai
force-pushed
the
ewm_ignore_nulls
branch
from
578a87b
to
378f52a
Compare
|
@yuntai, @ritchie46: This is looking great; I've validated the calculation results (via parametric testing) and it ties-out nicely. Bonus points: seems it's ~20% faster 👍 |
|
That's great to hear. Thanks @yuntai for PR and thanks @alexander-beedie for validating this as I am not really familiar with the algorithm. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_nullsI am not familar with making a binary expression but ewm_cov can be readily added to the API