Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python): Consistently parse column name inputs #6879

Merged
merged 1 commit into from
Feb 15, 2023
Merged

refactor(python): Consistently parse column name inputs #6879

merged 1 commit into from
Feb 15, 2023

Conversation

stinodego
Copy link
Member

Changes:

  • Dispatch the following DataFrame methods to the LazyFrame equivalent:
    • drop_nulls
    • drop
    • unique
  • Make sure all methods that specify a column name or list of column names are handled consistently:
    • Similar type hints
    • Similar parsing
    • Similar docstring description

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality labels Feb 14, 2023
@ritchie46
Copy link
Member

Just a rebase away. 👍

@ritchie46 ritchie46 self-requested a review February 15, 2023 07:18
@stinodego stinodego merged commit d24bd44 into pola-rs:master Feb 15, 2023
@stinodego stinodego deleted the rename-exprs-columns-subset branch February 22, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

Assignees
No one assigned
Labels
python Related to Python Polars refactor Code improvements that do not change functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @ritchie46