fix(python): prevent conflation of unit.io tests directory with python io module
#6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uses errors if tests run relative to "unit" root)
alexander-beedie
changed the title
unit.io tests directory with io moduleunit.io tests directory with python io module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tests are run relative to
unit, theiodirectory can mask theiomodule (because it has an unnecessary__init__), leading to the following fatal Python error:Removing the
__init__allows for proper resolution of the builtiniomodule (and doesn't impact running the tests).(Note: this shows up most readily when attempting to debug tests from PyCharm)