Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust, python): don't pack integer keys in determining ~8-18% group tuples. #6956

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Feb 17, 2023

Benchmarking some old assumptions.

Cleanes up code and is faster.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 17, 2023
@ritchie46
Copy link
Member Author

Also fixes 2 bugs introduced in latest 2 commits.

@ritchie46 ritchie46 merged commit cd9a843 into master Feb 17, 2023
@ritchie46 ritchie46 deleted the no_pack branch February 17, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant