test(python): date-time unit tests refactor #7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
MatveyF
force-pushed
the
test(python)/test_datetime_py_refactor
branch
from
7433543
to
33641bf
Compare
stinodego
reviewed
Feb 19, 2023
|
Looks like a nice improvement to me! Thanks. I left just one comment - if you could address that, we can go ahead and merge this. |
|
Thank you for your review and feedback, I will change the fixtures later today. |
Testing for different cases, including skewed case - when one of the functions would have worked but the other failed.
… `Series` name assignments.
…t_times`, `test_strptime_epoch`, and `test_strptime_fractional_seconds`. Applied `parametrize` where applicable
…test_epoch_matches_timestamp`
MatveyF
force-pushed
the
test(python)/test_datetime_py_refactor
branch
from
33641bf
to
e14a38b
Compare
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
test_datetime.pyto utilize morepytest.Changes:
parametrizetest_median&test_meanparameters updated as suggested by @stinodego in fix(python): typo in mean unit test - changedmedian->mean#6960test_dt_datetimesinto three separate unit testsPlease note that the actual testing logic has been barely altered. Open to any suggestions and improvements.