perf(rust, python): improve single argument elementwise expression pe… #7180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rformance in groupby context
github-actions
bot
added
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rformance in groupby context
This greatly simplifies the expressions by not exploding anymore to do elementwise operations in the groupby context. This explode could also lead to a full realloc (if it could not fast explode), and often lead to a recomputation of the groups.
When the groups overlapped (e.g. in groupby dynamic), the explode could lead to an explosion of memory usage. So all in all, small change, but a lot of benefit.