fix(python): detect deltalake version in show_versions #7622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we did not pick up the version of the optional deltalake dependency, as per delta-io/delta#1339. Solved this using importlib.metadata. This standard library function is not availble for Python 3.7, but I dont think it is worth adding the backport for that given support may soon be lost and there is no significant loss in functionality to end users.
ritchie46
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we did not pick up the version of the optional deltalake dependency, as per delta-io/delta#1339.
Solved this using importlib.metadata. This standard library function is not availble for Python 3.7, but I dont think it is worth adding the backport for that given Python 3.7 support may soon be dropped and there is no significant loss in functionality to end users.