Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Rename argument f to function in reduce docstring #7925

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Apr 1, 2023

Otherwise we get a deprecation warning.

@github-actions github-actions bot added chore Maintenance work that does not impact the user python Related to Python Polars labels Apr 1, 2023
@zundertj zundertj changed the title chore(python): Rename deprecated argument f to function in reduce… chore(python): Rename argument f to function in reduce docstring Apr 1, 2023
@stinodego stinodego merged commit 27d2e4a into pola-rs:master Apr 3, 2023
@stinodego
Copy link
Contributor

Thanks - we should really fail the doctests on DeprecationWarnings, like we do in the regular test suite.

chitralverma pushed a commit to chitralverma/polars that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants