fix(python): Truncate long column name in glimpse #8281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncate column names longer than 50 characters to 47 characters + "...". Extremely long column names (say 90+ characters, depending on dtypes present) caused an issue as `max_col_values` would become negative. Truncating to 50, plus 10? for dtypes leaves always 100-50-10=40 characters for the first couple of values.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate column names longer than 50 characters to 47 characters + "...".
Extremely long column names (say 90+ characters, depending on dtypes present) caused an issue as
max_col_valueswould become negative. Truncating to 50, plus 10? for dtypes leaves always 100-50-10=40 characters for the first couple of values.Tried to see if
textwrap.shorten(in stdlib) would be of use, but that works only for words in a sentence, not characters, unfortunately.Fixes #8273.