Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): Remove _tempdir module references #9427

Merged
merged 1 commit into from
Jun 19, 2023
Merged

chore(python): Remove _tempdir module references #9427

merged 1 commit into from
Jun 19, 2023

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Jun 18, 2023 •
edited
Loading

The module polars.testing._tempdir does no longer exist, so we can remove the mypy and stacklevel references made to it.

@zundertj
chore(python): Remove _tempdir module references
8f954de 
The module `polars.testing._tempdir` does no longer exists, so we can remove the mypy and stacklevel references made to it.
@github-actions github-actions bot added chore Maintenance work that does not impact the user python Related to Python Polars labels Jun 18, 2023
@zundertj zundertj requested a review from stinodego June 18, 2023 14:36
stinodego
stinodego approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@stinodego stinodego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I missed these.

@zundertj It's still on draft... can this be merged?

@zundertj zundertj marked this pull request as ready for review June 19, 2023 18:01
@zundertj
Copy link
Collaborator Author

Ready for merge!

@alexander-beedie alexander-beedie merged commit 62ac540 into pola-rs:main Jun 19, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@zundertj @c-peters
chore(python): Remove _tempdir module references (pola-rs#9427)
9b3304a
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zundertj @stinodego @alexander-beedie