refactor(python): Warn for future change of closed default value in rolling functions #9470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olling functions Only warn if `by` has been set to a non-None value, otherwise `closed` is not applicable in the first place.
zundertj
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
python
2 tasks
MarcoGorelli
approved these changes
Jun 20, 2023
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only warn if
byhas been set to a non-None value, otherwiseclosedis not applicable in the first place.See #9193