Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): remove false "eager=True" from date_range tests #9663

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

In date_range, there is

if (
not eager
or isinstance(start, (str, pl.Expr))
or isinstance(end, (str, pl.Expr))
):
start = parse_as_expression(start)
end = parse_as_expression(end)
expr = wrap_expr(plr.date_range_lazy(start, end, interval, closed, time_zone))
if name is not None:
expr = expr.alias(name)
return expr

So in effect, currently, if start or end are expressions, then an expression will be returned, and eager=True takes no effect (as is technically a lie?)

Noticed this while working on #9019, this'll help reduce the diff

@github-actions github-actions bot added chore Maintenance work that does not impact the user python Related to Python Polars labels Jul 1, 2023
@stinodego stinodego merged commit 5c76bbf into pola-rs:main Jul 1, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants