Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): Add various unit tests #9903

Merged
merged 2 commits into from
Jul 15, 2023
Merged

chore(python): Add various unit tests #9903

merged 2 commits into from
Jul 15, 2023

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Jul 15, 2023 •
edited
Loading

And remove unused code.

@github-actions github-actions bot added chore Maintenance work that does not impact the user python Related to Python Polars labels Jul 15, 2023
stinodego
stinodego reviewed Jul 15, 2023
View reviewed changes
Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always good to have some more tests! Just two small comments.

py-polars/tests/unit/test_cfg.py Show resolved Hide resolved
py-polars/polars/dataframe/frame.py Outdated Show resolved Hide resolved
stinodego
stinodego approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@stinodego stinodego merged commit ed7724c into pola-rs:main Jul 15, 2023
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zundertj @stinodego