-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and improve $scan/read_parquet()
#492
Conversation
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
@eitsupi sorry for circling around the match.call eval. I noticed in new utest How about pl$read_parquet(x,y,z) {
args = as.list(environment())
result({
do.call(pl$scan_parquet, args)$collect()
}) |>
unwrap("in pl$read_parquet(): ")
} |
This looks more robust indeed |
Actually I am not familiar with these but they seem to work well, thanks! |
Merge remote-tracking branch 'origin/parquet_err' into parquet_err # Conflicts: # R/parquet.R # tests/testthat/test-parquet.R
Thanks! I'll just tweak a few things before merging |
$scan/read_parquet()
No description provided.