fix posixct conv back and forth #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Dec 10, 2023
eitsupi
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Thanks for this update.
@sorhawell I tweak the tests. Does this make sense?
Comment on lines
+53
to
+56
| expect_identical( | ||
| pl$lit(as.POSIXct("2022-01-01", tz = "GMT"))$to_r(), | ||
| as.POSIXct("2022-01-01", tz = "GMT") | ||
| ) |
There was a problem hiding this comment.
this test is the same as the second one
There was a problem hiding this comment.
Testing regarding data type mapping definitely needs to be improved.
I think we can merge this into a follow-up task for now.
There was a problem hiding this comment.
As you want but adding a # TODO or removing the identical test takes the same time ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #578