-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump polars to unreleased 2023-12-21 version #601
Conversation
Can we wait for rust-polars 0.36? It is just easier to bump when there's a changelog for Rust-polars and we always bumped Rust versions when there was a rust-polars release. I can ask on discord when they plan to release 0.36 |
It's okay to wait, but since we don't know when it will be released, I thought it might be a good idea to release it with what we have now. @stinodego Are there any plans for the next release of Rust-polars? |
1.0.0 for Rust Polars is a long way off. It will definitely not coincide with 1.0.0 for Python Polars. I'm not sure when 0.36 comes out. The release cadence for Rust Polars is basically whenever Ritchie decides to press the button 😄 |
Thanks @stinodego :) @ritchie46 do you already have a date in mind (or an estimation)? |
I have fixed as many of the problems as I can but it is not complete yet. |
I'll work on this on Friday, maybe before. It would be amazing if rust-polars was bumped in the meantime but I'll continue this anyway |
I don't think the error in the describe example is directly related to this PR; describe in py-polars is written in python, which needs to be ported to R. |
We can use |
The state of library(polars)
temp_out <- tempfile()
pl$LazyFrame(mtcars)$sink_csv(temp_out) |
Strangely, it doesn't freeze when I give a string to the path argument. library(polars)
temp_out = tempfile()
temp_out
#> [1] "/tmp/RtmpXe0CL2/file3d5d188b4813"
pl$DataFrame(mtcars)$lazy()$sink_csv("/tmp/RtmpXe0CL2/file3d5d188b4813")
pl$DataFrame(mtcars)$lazy()$sink_csv(temp_out) Edit: Ah, sorry, now I know the cause. If I try to write to the same path a second time it freezes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' @return DataFrame | ||
pl$read_csv = function( | ||
read_csv = function( # remapped to pl$read_csv, a hack to support roxygen2 @inheritsParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool hack, nice to get rid of all these duplicated docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinks this is related to #560 and the function name should be pl_read_csv
.
This function should be add to the pl
environment when loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't reproduce the panics in rollbench code, so fine for me
Also should we bump the r-polars version in cargo.toml? |
I added |
Thanks for updates, @etiennebacher. |
The current version has never been released, so the same number is fine. |
It references the same commit as py-polars
0.20.00.20.2.I've been busy lately so I don't know if I'll be able to finish this, but I'd like to finish this and create a new release if possible.