Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Added Windows to CICD testing matrix, add hub integration test and fix errors #228

Merged
merged 35 commits into from
Dec 4, 2024
Merged

Testing: Added Windows to CICD testing matrix, add hub integration test and fix errors #228

merged 35 commits into from
Dec 4, 2024
+90 −85

Conversation

cwognum
Copy link
Collaborator

@cwognum cwognum commented Dec 3, 2024 •
edited
Loading

Changelogs

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

I created a dedicated test user in Clerk for this. It's credentials have been added to the secrets of this Github repository.

@cwognum cwognum added the test Annotates any PR that adds tests label Dec 3, 2024
@cwognum cwognum self-assigned this Dec 3, 2024
@cwognum cwognum changed the title Testing: Added Windows to CICD testing matrix and add integration test with Hub Testing: Added Windows to CICD testing matrix and fix errors Dec 3, 2024
@cwognum cwognum changed the title Testing: Added Windows to CICD testing matrix and fix errors Testing: Added Windows to CICD testing matrix, add hub integration test and fix errors Dec 3, 2024
cwognum
cwognum commented Dec 3, 2024
View reviewed changes
polaris/hub/client.py Outdated Show resolved Hide resolved
@cwognum cwognum linked an issue Dec 3, 2024 that may be closed by this pull request
Test: Integration tests of the PolarisHubClient #31
Closed
jstlaurent
jstlaurent approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but it looks very nice. 😄

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
polaris/hub/client.py Outdated Show resolved Hide resolved
polaris/hub/storage.py Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
cwognum and others added 3 commits December 4, 2024 08:41
@cwognum @jstlaurent
Update .github/workflows/test.yml
1d69031 
Co-authored-by: Julien St-Laurent <jstlaurent@users.noreply.github.com>
@cwognum @jstlaurent
Update polaris/hub/client.py
3531566 
Co-authored-by: Julien St-Laurent <jstlaurent@users.noreply.github.com>
@cwognum
PR review
f64f620
mercuryseries
mercuryseries approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@mercuryseries mercuryseries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @cwognum! Thanks.

.github/workflows/doc.yml Outdated Show resolved Hide resolved
@cwognum cwognum merged commit 5b3e9f6 into main Dec 4, 2024
10 checks passed
@cwognum cwognum deleted the test/windows branch December 4, 2024 19:59
@cwognum cwognum mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstlaurent jstlaurent jstlaurent approved these changes

@mercuryseries mercuryseries mercuryseries approved these changes

@Andrewq11 Andrewq11 Awaiting requested review from Andrewq11

Assignees

@cwognum cwognum

Labels
test Annotates any PR that adds tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue running the base example on Windows Test: Integration tests of the PolarisHubClient
3 participants
@cwognum @jstlaurent @mercuryseries