Misc changes

[mercuryseries]

Changelogs

• Fixes Standardize artifact_type typing in _get_v1_dataset, _upload_v1_dataset and _upload_benchmark #212
• Replace all occurences of tmpdir with tmp_path
• Update list_datasets and list_benchmarks to include support for v2 artifacts.

---

Checklist:

• Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
• Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
• Update the API documentation if a new function is added, or an existing one is deleted.
• Write concise and explanatory changelogs above.
• If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

---

discussion related to that PR

[jstlaurent]

👍

[cwognum]

Thanks, @mercuryseries !

[cwognum]

Thanks, @mercuryseries !

Why the many string conversions? The test cases weren't failing, so I assume it's to be consistent with typing? If so, what do you think about instead extending the type hints to also accept a Path ? That seems to actually be the more appropriate type here anyways.

[mercuryseries]

Why the many string conversions? The test cases weren't failing, so I assume it's to be consistent with typing? If so, what do you think about instead extending the type hints to also accept a Path ? That seems to actually be the more appropriate type here anyways.

Yes, I agree that extending the type hints to accept Path would be more appropriate. I considered doing that during the refactoring, but decided to hold off because the datamol.utils.fs.join function, which is used in some places, currently accepts a variable number of str: https://docs.datamol.io/0.7.15/api/datamol.utils.html#datamol.utils.fs.join. While it does internally convert input paths to str if you pass them in, the type hints don't reflect that. So, to properly support Path inputs, we'd need to update the type annotations of join and possibly other related functions.

[cwognum]

@jstlaurent has repeatedly told me to not (ab)use Datamol for its filesystem... Old habits die hard... The use of datamol.utils.fs.join should be considered legacy code. Ideally, we should replace this with methods such as os.path.join (for local paths) or urllib.parse.urljoin (for URLs). I'm okay with leaving that outside the scope of this PR though.