-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Client support for competitions #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Andrewq11 !
I left some comments. Nothing major!
@cwognum going to mark this ready for review despite missing those couple docs and tutorial. Everything else should be ready 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, nice work. I did have some questions/suggestions. Since Andrew is out, I can take a stab at implementing them.
@jstlaurent If you have the time, it would be great if you could take a stab at this. I was planning to take over from Andrew, but there are some other things on my plate I would really like to wrap before EOY so we can hit the ground running in 2025. |
ffbb2e9
to
3805d0c
Compare
…ion inherit from BenchmarkSpecification.
65e8ac7
to
33d72c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick. Looks good. 🚢 it!
Changelogs
CompetitionSpecification
class that inherits from theDatasetV2
classCompetitionPredictions
class that inherits from theBenchmarkPredictions
class for standardized prediction uploadsArtifactSubtype
)CompetitionResults
class since these results never reach the client currentlyChecklist:
feature
,fix
,chore
,documentation
ortest
(or ask a maintainer to do it for you).Important Notes
This PR is ready in terms of features, but is currently missing:
I will leave this PR as a draft to gather comments while I work on these next.