Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Adapt the -/+ 10s buttons #13

Closed
oas777 opened this issue Jan 6, 2023 · 10 comments
Closed

Design: Adapt the -/+ 10s buttons #13

oas777 opened this issue Jan 6, 2023 · 10 comments
Labels
design Design

Comments

@oas777
Copy link
Collaborator

oas777 commented Jan 6, 2023

Compared to https://tinyurl.com/2gox7lms, they are too large and not aligned horizontally. Please also check the font is the same as other buttons in the control bar.
play

@miesgre miesgre added the design Design label Jan 10, 2023
@miesgre
Copy link
Collaborator

miesgre commented Feb 22, 2023

@oas777 We updated the player. Can you test it works as expected?
Demo: https://polimediaupv.github.io/paella-ethz/?id=belmar-multiresolution-remote

@oas777
Copy link
Collaborator Author

oas777 commented Feb 26, 2023

Almost... the "Forward 10 seconds" button is cut off on the right side. And maybe you could align the numbers "10" with the playback rate number horizontally?
10seconds

@oas777
Copy link
Collaborator Author

oas777 commented Feb 26, 2023

10seconds

@miesgre
Copy link
Collaborator

miesgre commented Feb 27, 2023

Almost... the "Forward 10 seconds" button is cut off on the right side.
10seconds

It's a bug in Windows, in OSX works correctly. We will try to fix it.

And maybe you could align the numbers "10" with the playback rate number horizontally?
10seconds

The time text is aligned to be vertically center and the back/forward icons are aligned in the same size and positions as the rest of the icons (play, volume, etc...).

In Lisa's designs the text is not aligned:
Captura de pantalla 2023-02-27 a las 11 21 32

But, If you want it aligned we can:

  1. Down the time text:
    Captura de pantalla 2023-02-27 a las 11 08 05

  2. Up the back/forward icons. But the there will not be aligned to the rest of the icons:
    Captura de pantalla 2023-02-27 a las 11 06 11

@oas777
Copy link
Collaborator Author

oas777 commented Feb 27, 2023

You're right, Lisa didn't align them, but I like the second option better:
image
What do you think? What does Carlos think?

@miesgre
Copy link
Collaborator

miesgre commented Feb 27, 2023

I prefer the lisa's design. The second option, the icon is not aligned inside the button and I find it annoying. But is'a a personal opinion.
221567476-5257a6ac-33d0-4021-b1e0-e8992e53858b

@turro What do you think?

@turro
Copy link

turro commented Feb 28, 2023

I am not a visual design expert, but I like more the aligned numbers like Olaf said ;-)

@miesgre
Copy link
Collaborator

miesgre commented Mar 2, 2023

I aligned the text as second option.
Demo: https://polimediaupv.github.io/paella-ethz/?id=belmar-multiresolution-remote

@miesgre
Copy link
Collaborator

miesgre commented Mar 2, 2023

I aligned the text as second option.
Demo: https://polimediaupv.github.io/paella-ethz/?id=belmar-multiresolution-remote

It should also fix the cut off text in windows

@oas777
Copy link
Collaborator Author

oas777 commented Mar 2, 2023

Looks, good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design
Projects
None yet
Development

No branches or pull requests

3 participants