-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Paella skin #938
Add new Paella skin #938
Conversation
17cd88c
to
e6f7e1c
Compare
I like the center aligned version.
I like the semi-transparent background and would even suggest to make it even more transparent. What I do not like so much is the hover over effect. I would not apply it here like this the hover over effect. |
|
Hover-over: Yes, this might help by heightening the contrast. Personally, I do not find it pretty when the bar becomes fully opaque. |
Re button alignment: I very slightly adjusted the positioning of the buttons and also of the text within the icons. It's still mostly centered, but the text is also less off the baseline. Let me know what you think. I read the thread Olaf linked and I understand the "text baseline alignment" reasoning, but I think it has a big disadvantage: when you hover the button, the icon inside the blue area looks super misaligned. I asked internally here and so far everyone prefers the center aligned version, including our designer after she saw the hover screenshot. But that's surely something we can discuss further and yes, maybe just let Lisa decide in the end! Re transparency: I decreased the opaqueness of the toolbar background from 85% to 80% (idle) and 100% to 90% (on hover), as per suggestion. Let me know what you think! |
I've tried using the configured primary color as "accent color" in Paella, but unfortunately that doesn't quite work yet. I described the problem here: polimediaupv/paella-skins#3 |
One more update: I added a slight transition animation between the "on hover" background transparency and the normal one. Maybe that makes the on hover effect a bit less jarring? |
To @LukasKalbertodt adjustments:
Additional observation:
|
Before, when your mouse cursor entered the playbar area, the background color switched immediately from 85% opaque to 100% opaque. An immediate change. Now it takes 80ms for this change to happen, where the background color changes gradually during that time. I hope this explains it?
Totally agree. It also immediately annoyed me. Will try to find a way to change this. EDIT: Unfortunately, this cannot be changed right now. I created two upstream issues: |
|
1c1663d
to
b0f7506
Compare
|
Fernando replied in one of the issues I created and explained that it's already configurable. Not via config file, but via code. So Tobira can already configure it, which I did with the latest "commit". You can check in the test deployment whether 2s feel right for you. Keep in mind that in the future, the UI will be immediately hidden if oyu move the cursor outside of the player area. |
Thanks. Two seconds work for me. In an ideal world, the hiding would be less abrupt/smoother. |
Two seconds work for me, too. But I'm looking forward to this future, where the UI will be immediately hidden. |
This comment was marked as resolved.
This comment was marked as resolved.
b0f7506
to
b384a18
Compare
I don't really expect this code to end up in Tobira. If everyone agrees that this is a good thing, this should go upstream.
b384a18
to
aaebda4
Compare
Okay, so as far as I can tell the only thing that's left is using Tobira's configured "primary color" for Paella, instead of the Paella default blue. Is my understanding correct or is there anything else that still has to change? |
Looks good so far, but features/symbols on the right side of the control bar are missing, cf. https://polimediaupv.github.io/paella-ethz/?id=belmar_16_9_hls. |
From right to left:
|
We decided that we can already merge this without the correct colors. We can always fix that later and this is already a big improvement obviously. |
To add to the confusion, not only does the "version" we use in Tobira now differ from https://polimediaupv.github.io/paella-ethz/?id=belmar_16_9_hls, but that one differs from what we agreed with UPV (background should be white, e. g.). Let's revisit this at a later stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the background of the video container should be either black or white, or rather just not be visible at all by making the whole UI scale with the video, though that also comes with a few caveats. But yeah, let's discuss that in another issue. For now I'm happy that the new skin finally arrives in Tobira.
Closes #918
Is still a draft for multiple reasons:
Open questions
Button alignment
I took the liberty and center aligned all button icons:
But the design itself wants to do it like this:
Opinions?
Semi-transparent background
I also made the toolbox background semi-transparent, which is also not part of the original design:
On hover it becomes fully opaque. What do you think about this?