Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply updated ETH/Opencast paella skin #918

Closed
owi92 opened this issue Aug 15, 2023 · 0 comments · Fixed by #938
Closed

Apply updated ETH/Opencast paella skin #918

owi92 opened this issue Aug 15, 2023 · 0 comments · Fixed by #938
Assignees
@LukasKalbertodt
Labels
area:frontend Everything frontend related area:player Paella and its integration in Tobira kind:improvement

Comments

@owi92
Copy link
Member

owi92 commented Aug 15, 2023

The new skin can be found at: https://www.npmjs.com/package/paella-skins
@owi92 owi92 added kind:improvement area:player Paella and its integration in Tobira area:frontend Everything frontend related labels Aug 15, 2023
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Sep 13, 2023
@LukasKalbertodt LukasKalbertodt self-assigned this Sep 13, 2023
@LukasKalbertodt LukasKalbertodt mentioned this issue Sep 18, 2023
Merged
4 tasks
@LukasKalbertodt LukasKalbertodt moved this from Todo to In Progress ⏳ in Tobira Sep 19, 2023
@LukasKalbertodt LukasKalbertodt moved this from In Progress ⏳ to In Review 👀 in Tobira Sep 28, 2023
owi92 added a commit that referenced this issue Sep 28, 2023
@owi92
Add new Paella skin (#938)
daa3ed5 
Closes #918 

Is still a draft for multiple reasons:
- [x] There were some bugs in the Paella package. I already opened a PR
fixing those. polimediaupv/paella-skins#1
- [ ] I still have to figure out how to best use Tobira's configured
"primary color" in Paella. Waiting on
polimediaupv/paella-skins#3
- [x] I want to update Paella to the newest version still.
- [x] There are some open questions.

## Open questions

### Button alignment

I took the liberty and center aligned all button icons:


![image](https://github.com/elan-ev/tobira/assets/7419664/c5532eb1-fcd0-451f-b030-b3b36716ae16)

But the design itself wants to do it like this:


![image](https://github.com/elan-ev/tobira/assets/7419664/736c2002-18a9-4c0b-b4e9-56d4b791607c)

Opinions?

### Semi-transparent background

I also made the toolbox background semi-transparent, which is also not
part of the original design:


![image](https://github.com/elan-ev/tobira/assets/7419664/f4ff99a5-c5b9-4fcf-88ad-a6ef7befc09c)

On hover it becomes fully opaque. What do you think about this?
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✔️ in Tobira Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasKalbertodt LukasKalbertodt

Labels
area:frontend Everything frontend related area:player Paella and its integration in Tobira kind:improvement
Projects
Tobira
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new Paella skin LukasKalbertodt/tobira
2 participants
@LukasKalbertodt @owi92