Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slideMapProgressBarPlugin from configOverrides in skins/opencast/theme.json #6

Open
owi92 opened this issue Jul 10, 2024 · 8 comments

Comments

@owi92
Copy link

owi92 commented Jul 10, 2024

Hi,
@oas777 suggested in elan-ev/tobira#1196 (comment) that he would prefer a different color for the vertical lines of the slide map progress bar (or rather just disabling their change in color on hover).
If I understand it correctly, that appears to be overidden in theme.json which we copy in Tobira to match Opencast's paella integration, and it doesn't seem to be customizable in Tobira itself.

Is it possible to make it either customizable or otherwise disable it? Maybe it could be removed from the configOverrides, but I'm not sure what the best approach is here.

I also understand that the purpose of this theme is to have these styles fixed and easily shared between projects so I can see this issue being somewhat controversial.

@miesgre
Copy link
Collaborator

miesgre commented Jul 12, 2024

Hi @owi92!

We can remove the slideMapProgressBarPlugin from theovwrrides. But then the colors from config.json will be applied.

It would not be the same color for everyone who uses the theme. If that's what you want, no problem. Please talk to Lukas/Olaf and tell me.

@oas777
Copy link

oas777 commented Jul 12, 2024

Thanks, @miesgre. To be honest, my suggestion to change the color/behavior of the vertical "dividers" is just a workaround. What I really want is for them to be reduced to the height of the bar they are dividing:
image
Admittedly, this is a design question, compared to
image

So could you please give me some background information on why the dividers are the way they are?

@miesgre
Copy link
Collaborator

miesgre commented Jul 16, 2024

What do you think?

Captura de pantalla 2024-07-16 a las 8 08 15

@oas777
Copy link

oas777 commented Jul 16, 2024

Visually, that's exactly what I was thinking of, thank you. But why are there still vertical lines (higher than the horizontal line) you are hiding? What is their use case?
@owi92, @LukasKalbertodt, what do you think?

@miesgre
Copy link
Collaborator

miesgre commented Jul 16, 2024

Yes, it is the only thing I can do without having to modify the plugin.
In the skin I can only play with the colors. The idea is to put the lines the same color as the background and adjust their thickness.

I will select the same exact color. It was a quick test to see if that was what you wanted.

@oas777
Copy link

oas777 commented Jul 16, 2024

+1

@owi92
Copy link
Author

owi92 commented Jul 16, 2024

@miesgre that was my initial idea as well, but I think that won't work with the hover style, right?
I suppose that could also use the same color as the background, but then it wouldn't have any purpose.
So it would really be best if the marks were reduced to the height of the progress bar, as @oas777 suggested.

This was my mistake, I believe I should have opened this issue in the paella-slide-plugins repository instead.

@LukasKalbertodt
Copy link
Contributor

I agree that just changing the bar color to the background color doesn't work, especially in cases where the background is semi-transparent (like in Tobira). And like, in this comment I still clearly see the bars on top of the background. So I agree with Ole in that the plugin needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants