-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove slideMapProgressBarPlugin
from configOverrides
in skins/opencast/theme.json
#6
Comments
Hi @owi92! We can remove the It would not be the same color for everyone who uses the theme. If that's what you want, no problem. Please talk to Lukas/Olaf and tell me. |
Thanks, @miesgre. To be honest, my suggestion to change the color/behavior of the vertical "dividers" is just a workaround. What I really want is for them to be reduced to the height of the bar they are dividing: So could you please give me some background information on why the dividers are the way they are? |
Visually, that's exactly what I was thinking of, thank you. But why are there still vertical lines (higher than the horizontal line) you are hiding? What is their use case? |
Yes, it is the only thing I can do without having to modify the plugin. I will select the same exact color. It was a quick test to see if that was what you wanted. |
+1 |
@miesgre that was my initial idea as well, but I think that won't work with the hover style, right? This was my mistake, I believe I should have opened this issue in the paella-slide-plugins repository instead. |
I agree that just changing the bar color to the background color doesn't work, especially in cases where the background is semi-transparent (like in Tobira). And like, in this comment I still clearly see the bars on top of the background. So I agree with Ole in that the plugin needs to be adjusted. |
Hi,
@oas777 suggested in elan-ev/tobira#1196 (comment) that he would prefer a different color for the vertical lines of the slide map progress bar (or rather just disabling their change in color on hover).
If I understand it correctly, that appears to be overidden in
theme.json
which we copy in Tobira to match Opencast's paella integration, and it doesn't seem to be customizable in Tobira itself.Is it possible to make it either customizable or otherwise disable it? Maybe it could be removed from the
configOverrides
, but I'm not sure what the best approach is here.I also understand that the purpose of this
theme
is to have these styles fixed and easily shared between projects so I can see this issue being somewhat controversial.The text was updated successfully, but these errors were encountered: