-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust-weechat & matrix-sdk #86
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Not a real review for now, just wanted to thank you for doing this. |
No problem, I created both PRs as drafts for now since I'm combing through the codebase trying to map how it works (looks clean and simple to me :) but also because I'm trying to fix the usage first; and once I'm sure that it's usable for others, I'll clean it up for proper review (I don't mind nitpicks and suggestions though). I'm trying to use matrix solely via weechat, so far the only offenders have been BIG rooms (like |
Yeah, WeeChat itself has trouble dealing with that many nicks in the nicklist, the Python version of this plugin had to introduce such a limit as well. There are some new APIs in the Matrix Rust SDK and Matrix Spec which should help with the initial sync itself taking a lot of data, but that's a topic for the future. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Also since matrix.org switched to authenticated media, I'm not exactly sure how to handle the mxc URLs since putting the token in query is not advised (also super bad) |
Yeah, you would probably need a small helper of some sort which knows the access token, or you could keep it in the query and the small helper puts the token into the header. Ideally we would also use the URL escape code so we hide all the unnecessary data the URL needs to contain. |
Fixed now |
Remove unused indoc/syntect dependencies
I've removed temp fixes for too many users syncing, clippy and others, making this PR mostly just a compile fix (with few replaced panics) and removing not needed dependencies. I'll work sliding sync filters and optimisations in new PR. In terms of duplicated dependencies:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for simplifying this, I tested this and it did work for me as well.
I think we can merge this.
related: poljar/rust-weechat#36