Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use-macros-in-a-custom-pallet.md #2094

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Update use-macros-in-a-custom-pallet.md #2094

merged 1 commit into from
Dec 11, 2023

Conversation

Euraxluo
Copy link
Contributor

@Euraxluo Euraxluo commented Dec 4, 2023

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for substrate-docs ready!

Name Link
🔨 Latest commit 5712e73
🔍 Latest deploy log https://app.netlify.com/sites/substrate-docs/deploys/656df6ddfdf8ea000869c595
😎 Deploy Preview https://deploy-preview-2094--substrate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Euraxluo
Copy link
Contributor Author

Euraxluo commented Dec 7, 2023

@liamaharon

liamaharon
liamaharon reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this compile if followed step-by-step? Does the dev also need to define BlockNumberFor?

@Euraxluo
Copy link
Contributor Author

Euraxluo commented Dec 7, 2023 •
edited
Loading

Will this compile if followed step-by-step?

Yes,i am a beginner, i found this method, through the compilation,so update the doc

@Euraxluo
Copy link
Contributor Author

Euraxluo commented Dec 7, 2023 •
edited
Loading

Does the dev also need to define BlockNumberFor?

noting more to be done,just step by step

@Euraxluo
Copy link
Contributor Author

Euraxluo commented Dec 9, 2023

@jonnysmillie

@jonnysmillie jonnysmillie merged commit 8553b97 into polkadot-developers:main Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Euraxluo @liamaharon @jonnysmillie