Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Substrate to polkadot-sdk #1193

Closed
wants to merge 5 commits into from
Closed

Upgrade Substrate to polkadot-sdk #1193

wants to merge 5 commits into from

Conversation

nazar-pc
Copy link

This is a straightforward mechanical upgrade, nothing fancy here, mostly things were simplified a bit upstream.

The first step is to catch up with old repo, after this upgrade to polkadot-sdk should be much easier.

@nazar-pc
Copy link
Author

Not sure about integration tests, but regular tests all succeeded for me locally, while CI seems to be broken here

@koushiro
Copy link
Collaborator

There is already a PR #1165 for upgrading substrate.
There is also a PR #1191 to fix CI.

@nazar-pc
Copy link
Author

Hm, I somehow didn't notice #1165. Why not upgrading to latest version there though?

@nazar-pc nazar-pc changed the title Upgade Substrate old repo Upgrade Substrate old repo Sep 13, 2023
@koushiro
Copy link
Collaborator

Why not upgrading to latest version there though?

I usually only update the substrate deps of frontier's master branch when the team releases a new version of polkadot. This can reduce maintenance work, and the master branch of substrate usually does not have good stability.

@koushiro
Copy link
Collaborator

It seems that polkadot is about to release v1.1.0, and then we can directly migrate to polkadot-sdk repo

@nazar-pc nazar-pc force-pushed the upgade-substrate-old-repo branch 3 times, most recently from 597ceb2 to 7d90c6d Compare September 13, 2023 08:07
@nazar-pc
Copy link
Author

Rebased against newly merged PRs in master

@nazar-pc
Copy link
Author

Fixed lints as well

@nazar-pc nazar-pc mentioned this pull request Sep 13, 2023
Merged
1 task
@nazar-pc nazar-pc changed the title Upgrade Substrate old repo Upgrade Substrate to polkadot-sdk Sep 14, 2023
@nazar-pc
Copy link
Author

Pulled current master of polkadot-sdk, only new changes were a few imports that changed during refactoring.

@nazar-pc nazar-pc mentioned this pull request Sep 14, 2023
Merged
1 task
@sorpaas
Copy link
Member

sorpaas commented Sep 25, 2023

superseded by #1201

@sorpaas sorpaas closed this Sep 25, 2023
@nazar-pc nazar-pc deleted the upgade-substrate-old-repo branch September 25, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazar-pc @koushiro @sorpaas