Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EVM pallet to FRAMEv2 #380

Merged
merged 1 commit into from
May 8, 2021

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented May 8, 2021

No description provided.

@KiChjang KiChjang requested a review from sorpaas as a code owner May 8, 2021 02:15
@KiChjang KiChjang changed the title Upgrade EVM pallet to FRAMEv3 Upgrade EVM pallet to FRAMEv2 May 8, 2021
@sorpaas
Copy link
Member

sorpaas commented Jun 14, 2021

I'm going to temporarily revert this PR because we want to release Frontier to crates.io.

pallet attributes macro was technically released with Substrate 3.0, but it later still went through some changes. With that it's almost impossible to have a version that support both Substrate 3.0 and Substrate master. Using the old decl_modules macro we can completely avoid this problem.

sorpaas added a commit that referenced this pull request Jun 14, 2021
sorpaas added a commit that referenced this pull request Aug 23, 2021
sorpaas added a commit that referenced this pull request Aug 23, 2021
* Revert "Revert "Upgrade EVM pallet to FRAMEv2 (#380)""

This reverts commit 713165e.

* Run rustfmt on the code

* Fix tests compile
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
* Revert "Revert "Upgrade EVM pallet to FRAMEv2 (polkadot-evm#380)""

This reverts commit 713165e.

* Run rustfmt on the code

* Fix tests compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants