Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Some Treasury Configs to NeverEnsure Once v1.5.0 is Released #113

Closed
joepetrowski opened this issue Dec 8, 2023 · 0 comments · Fixed by #137
Closed

Convert Some Treasury Configs to NeverEnsure Once v1.5.0 is Released #113

joepetrowski opened this issue Dec 8, 2023 · 0 comments · Fixed by #137

Comments

@joepetrowski
Copy link
Contributor

joepetrowski commented Dec 8, 2023 •
edited
Loading

Some of the pallet_treasury config items in the Polkadot Fellowship will require updating once NeverEnsure is available. These have been marked with links to this issue.

          we should have issues linking to todos to remind people there are future work to be done

Originally posted by @xlc in #109 (comment)
@bkontur bkontur mentioned this issue Feb 13, 2024
Merged
8 tasks
bkontur added a commit to bkontur/runtimes that referenced this issue Feb 13, 2024
@bkontur
[collectives] Removed older TODOs - addresing polkadot-fellows#113
e7dffea
bkchr pushed a commit that referenced this issue Feb 14, 2024
@bkontur @joepetrowski
Upgrade to latest polkadot-sdk@1.5 release (#137)
e5a723f 
Attached result of `cargo upgrade -v --pinned --incompatible`
[cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/13873056/cargo-upgrade-version-bump.log)

E.g.: `frame-support` from `25.0.0` to `27.0.0`

_Note: Encointer was not upgraded (because its pallet references
`polkadot@1.3.0` release)._

## TODO

- [x] fix compilation
- [x] fix integration tests
- [x] fix benchmarks (also try them)
- [ ] patch for `pallet-nomination-pools` migration fix
paritytech/polkadot-sdk#3094
- [x] patch for `xcm-executor` fix
paritytech/polkadot-sdk#3174
- [x] search for `TODO:(PR#137) - wait for xcm-executor patch` (missing
`FrameTransactionalProcessor`)
- [x] check/verify `MaxExposurePageSize = 512` / `MaxNominators = 512`
for Kusama/Polkadot
- [x] check with SRLabs (Jakob)
paritytech-secops/srlabs_findings#327


Closes: #113

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to latest polkadot-sdk@1.5 release bkontur/runtimes
1 participant
@joepetrowski