Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert paritytech/polkadot#6577 & related changes #169

Merged
merged 5 commits into from
Jan 31, 2024
Merged

revert paritytech/polkadot#6577 & related changes #169

merged 5 commits into from
Jan 31, 2024

Conversation

Lederstrumpf
Copy link
Contributor

Moves BEEFY pallets - in particular pallet_mmr - back behind pallet_session to address #160.

See paritytech/polkadot-sdk#3108 for the equivalent Rococo change.

@andresilva andresilva marked this pull request as ready for review January 30, 2024 14:36
@bkchr
Copy link
Contributor

bkchr commented Jan 30, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 30, 2024 14:39
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

bkchr
bkchr reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not just rename the pallets as otherwise their storage key will change!

relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
relay/polkadot/src/lib.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Contributor

You can not just rename the pallets as otherwise their storage key will change!

Damn good catch sir! My eyes missed that completely!

@bkchr
Copy link
Contributor

bkchr commented Jan 30, 2024

You can not just rename the pallets as otherwise their storage key will change!

Damn good catch sir! My eyes missed that completely!

I also missed that 🙈 I only have seen this because of CI failing 🙈

@andresilva
Copy link
Member

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@Lederstrumpf
Copy link
Contributor Author

You can not just rename the pallets as otherwise their storage key will change!

Damn good catch sir! My eyes missed that completely!

I also missed that 🙈 I only have seen this because of CI failing 🙈

Ah, sorry about that gross oversight! 🙈 I had left the PR in a draft state for a reason :P

@acatangiu
Copy link
Contributor

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@ggwpez ggwpez disabled auto-merge January 31, 2024 11:42
@ggwpez ggwpez enabled auto-merge (squash) January 31, 2024 11:42
@ggwpez ggwpez merged commit b09faa0 into polkadot-fellows:main Jan 31, 2024
15 checks passed
ggwpez pushed a commit that referenced this pull request Jan 31, 2024
@Lederstrumpf @bkchr @ggwpez
revert paritytech/polkadot#6577 & related changes (#169)
1cdde0a 
Moves BEEFY pallets - in particular `pallet_mmr` - back behind
`pallet_session` to address #160.

See paritytech/polkadot-sdk#3108 for the equivalent Rococo change.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
@acatangiu acatangiu mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lederstrumpf @bkchr @acatangiu @andresilva @ggwpez