Fix pallet_nis benchmark for Kusama runtime
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # relay/kusama/src/weights/pallet_balances_native.rs # relay/kusama/src/weights/pallet_balances_nis_counterpart.rs # relay/kusama/src/weights/pallet_nis.rs
acatangiu
approved these changes
Mar 11, 2024
ggwpez
approved these changes
Mar 11, 2024
eskimor
approved these changes
Mar 11, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 9566967
into
polkadot-fellows:main
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #223
A type alias
type Nis = pallet_balances::Pallet::<Runtime, NisCounterpartInstance>;for the secondpallet_balancesinstance was introduced here. Unfortunately, nobody (including myself) realized thatNisis also used for[pallet_nis, Nis]. As a result, the benchmark forpallet_nisruns as if it were forpallet_balances, and the result can be seen here: link.Therefore, this PR fixes this anomaly.